-
Notifications
You must be signed in to change notification settings - Fork 117
chore: lighter prod dependencies #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
We move development dependencies to devDependencies, such that `npm install --omit=dev` becomes faster and more lightweight. In the case of frontend-app-profile, this changes shaves off a few hundred MB of disk space.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 51 51
Lines 855 855
Branches 177 178 +1
=======================================
Hits 572 572
Misses 272 272
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @regisb! Just flagging some conflicts have popped up. |
Let's wait until we find an agreement here: openedx/frontend-platform#787 |
We move development dependencies to devDependencies, such that
npm install --omit=dev
becomes faster and more lightweight. In the case of frontend-app-profile, this changes shaves off a few hundred MB of disk space.