Skip to content

chore: lighter prod dependencies #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regisb
Copy link

@regisb regisb commented Apr 2, 2025

We move development dependencies to devDependencies, such that npm install --omit=dev becomes faster and more lightweight. In the case of frontend-app-profile, this changes shaves off a few hundred MB of disk space.

@regisb regisb requested a review from a team as a code owner April 2, 2025 10:14
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

We move development dependencies to devDependencies, such that `npm
install --omit=dev` becomes faster and more lightweight. In the case of
frontend-app-profile, this changes shaves off a few hundred MB of disk
space.
@regisb regisb force-pushed the regisb/dev-deps branch from 77b076c to c0e77bf Compare April 2, 2025 10:17
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (85d3eca) to head (c0e77bf).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files          51       51           
  Lines         855      855           
  Branches      177      178    +1     
=======================================
  Hits          572      572           
  Misses        272      272           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 7, 2025
@mphilbrick211
Copy link

Hi @regisb! Just flagging some conflicts have popped up.

@deborahgu deborahgu moved this to Backlog in Aperture-Maintained Apr 8, 2025
@deborahgu deborahgu moved this from Backlog to Todo in Aperture-Maintained Apr 8, 2025
@deborahgu deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 8, 2025
@regisb
Copy link
Author

regisb commented Apr 9, 2025

Let's wait until we find an agreement here: openedx/frontend-platform#787

@deborahgu deborahgu moved this to Blocked in Aperture-Maintained May 9, 2025
@deborahgu deborahgu added the blocked by other work PR cannot be finished until other work is complete label May 9, 2025
@deborahgu deborahgu moved this to Blocked in Aperture-Maintained May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Blocked
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants