feat: made profile editable #1212

eemaanamir · 2025-05-21T13:21:16Z

Summary:

Restored and enhanced the profile editing functionality in the Profile MFE, making it accessible to all users and aligned with the new Figma design.

Key Changes:

Editing Enabled for All Users

Removed the date of birth restriction on profile editing.

UI Updates

Implemented design changes based on the latest Figma specs.

Editable Fields Now Include:

Avatar
Full Name
Country
Language
Education
Bio
Social Links (Facebook, LinkedIn, X)

New Feature Toggle:

Introduced DISABLE_VISIBILITY_EDITING environment variable.
When set to true, the visibility toggle in the UI is hidden.

openedx-webhooks · 2025-05-21T13:21:21Z

Thanks for the pull request, @eemaanamir!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-05-22T08:19:08Z

Codecov Report

Attention: Patch coverage is 71.16564% with 141 lines in your changes missing coverage. Please review.

Project coverage is 68.23%. Comparing base (896f2ce) to head (449718b).
Report is 1 commits behind head on 2u-main.

Files with missing lines	Patch %	Lines
src/profile-v2/forms/SocialLinks.jsx	47.05%	27 Missing ⚠️
src/profile-v2/forms/PreferredLanguage.jsx	53.57%	13 Missing ⚠️
src/profile-v2/forms/elements/SwitchContent.jsx	40.90%	13 Missing ⚠️
src/profile-v2/data/selectors.js	88.17%	11 Missing ⚠️
src/profile-v2/data/services.js	47.61%	10 Missing and 1 partial ⚠️
src/profile-v2/forms/elements/FormControls.jsx	25.00%	9 Missing ⚠️
src/profile-v2/forms/elements/Visibility.jsx	50.00%	8 Missing ⚠️
src/profile-v2/ProfilePage.jsx	84.44%	6 Missing and 1 partial ⚠️
src/profile-v2/forms/Bio.jsx	68.18%	7 Missing ⚠️
src/profile-v2/forms/Country.jsx	69.56%	7 Missing ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff             @@
##           2u-main    #1212      +/-   ##
===========================================
- Coverage    68.73%   68.23%   -0.51%     
===========================================
  Files           72       92      +20     
  Lines         1222     1678     +456     
  Branches       273      412     +139     
===========================================
+ Hits           840     1145     +305     
- Misses         365      511     +146     
- Partials        17       22       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sundasnoreen12 · 2025-05-22T18:34:14Z

src/profile-v2/Certificates.jsx

            <FormattedMessage
              id="profile.certificates.description"
-              defaultMessage="Your learner records information is only visible to you. Only your username is visible to others on {siteName}."
+              defaultMessage="Your learner records information is only visible to you. Only your username and profile image is visible to others on {siteName}."


correct statement.
Your learner records information is only visible to you. Only your username and profile image are visible to others on {siteName}

sundasnoreen12 · 2025-05-22T18:38:02Z

src/profile-v2/ProfilePage.jsx

 import classNames from 'classnames';
+
+// Actions


remove all these comments

sundasnoreen12 · 2025-05-22T18:45:59Z

src/profile-v2/ProfilePage.jsx

+  const handleSubmit = useCallback((formId) => {
+    dispatch(saveProfile(formId, context.authenticatedUser.username));
+  }, [dispatch, context.authenticatedUser.username]);


const { username } = context.authenticatedUser;

const handleSubmit = useCallback((formId) => {
dispatch(saveProfile(formId, username));
}, [dispatch, username]);

sundasnoreen12 · 2025-05-22T18:52:54Z

src/profile-v2/ProfilePage.jsx

+            >
+              <div
+                className={classNames([
+                  'col h-100 w-100 px-0 justify-content-start g-15re',


i thinks spelling mistake it should be g-15rem

sundasnoreen12 · 2025-05-22T18:54:49Z

src/profile-v2/ProfilePage.jsx

+            <div
+              className={classNames([
+                'col container-fluid w-100 h-100 bg-white py-0 rounded-75',
+                isMobileView ? 'px-3' : 'px-25rem',
+              ])}
+            >


comparison should be like
className={classNames(
'col container-fluid w-100 h-100 bg-white py-0 rounded-75',
{
'px-3': isMobileView,
'px-25rem': !isMobileView,
}
)}

sundasnoreen12 · 2025-05-22T19:22:16Z

src/profile-v2/data/sagas.js

@@ -1,13 +1,16 @@
 import { history } from '@edx/frontend-platform';
 import { getAuthenticatedUser } from '@edx/frontend-platform/auth';
+import pick from 'lodash.pick';


import { pick } from 'lodash';

sundasnoreen12 · 2025-05-22T19:28:02Z

src/profile-v2/forms/Education.jsx

+import PropTypes from 'prop-types';
+import { connect } from 'react-redux';
+import { FormattedMessage, useIntl } from '@edx/frontend-platform/i18n';
+import get from 'lodash.get';


import { get } from 'lodash';

sundasnoreen12 · 2025-05-26T07:44:29Z

src/profile-v2/index.scss

+  background-color: #FBFAF9;
+}
+
+


remove this empty line

sundasnoreen12 · 2025-05-26T07:48:34Z

src/profile-v2/index.scss

+}
+
+.color-brand-500{
+    background-color: #D74000FF;


recheck the color code

sundasnoreen12 · 2025-05-26T07:50:08Z

src/profile-v2/data/sagas.test.js

        call(ProfileApiService.getPreferences, 'gonzo'),
+


remove this empty line

awais-ansari · 2025-05-23T10:03:44Z

src/profile-v2/ProfilePage.jsx

 import classNames from 'classnames';
+
+// Actions


Please remove this type of comment

awais-ansari · 2025-05-23T10:10:09Z

src/profile-v2/UserCertificateSummary.jsx

-  </span>
-);
+const UserCertificateSummary = ({ count = 0 }) => {
+  if (count !== 0) {


if (count) will also work

awais-ansari · 2025-05-24T11:09:51Z

src/profile-v2/__mocks__/invalidUser.mockStore.js

+    },
+    action: 'POP'
+  }
+};


add one extra empty line

awais-ansari · 2025-05-24T11:10:16Z

src/profile-v2/__mocks__/loadingApp.mockStore.js

@@ -38,4 +39,4 @@ module.exports = {
    },
    action: 'POP'
  }
-};
+};


add one extra empty line

awais-ansari · 2025-05-24T11:10:35Z

src/profile-v2/__mocks__/viewOtherProfile.mockStore.js

@@ -95,4 +102,4 @@ module.exports = {
    },
    action: 'POP'
  }
-};
+};


add one extra empty line

awais-ansari · 2025-05-26T07:29:24Z

src/profile-v2/index.scss

+}
+
+.pb-075rem{
+    padding-bottom: 0.75rem;


convert REM into PX and change color code with paragon color variables

awais-ansari · 2025-05-26T07:31:53Z

src/profile-v2/forms/elements/Visibility.jsx

+
+  return (
+    <span className={className}>
+      <span className="d-inline-block ml-1 mr-2" style={{ width: '1.5rem' }}>


remove hard style

awais-ansari · 2025-05-26T07:36:40Z

src/profile-v2/forms/Education.jsx

+  closeHandler,
+  openHandler,
+}) => {
+  const isVisibilityEnabled = getConfig().DISABLE_VISIBILITY_EDITING === 'true';


isVisibilityEnabled()

awais-ansari · 2025-05-26T07:40:24Z

src/profile-v2/forms/PreferredLanguage.jsx

+    if (name === formId) {
+      if (value !== '') {
+        changeHandler(name, [{ code: value }]);
+      } else {
+        changeHandler(name, []);
+      }
+    } else {
+      changeHandler(name, value);
+    }
+  };


awais-ansari · 2025-05-26T08:24:59Z

src/profile-v2/ProfilePage.jsx

 import { profilePageSelector } from './data/selectors';
 import messages from './ProfilePage.messages';
 import withParams from '../utils/hoc';
 import { useIsOnMobileScreen, useIsOnTabletScreen } from './data/hooks';

 ensureConfig(['CREDENTIALS_BASE_URL', 'LMS_BASE_URL'], 'ProfilePage');

-const ProfilePage = ({ params }) => {
+const ProfilePage = ({ params, navigate }) => {


direct import navigate

eemaanamir added 2 commits May 16, 2025 13:16

feat: readded editable fields to new profile view

5e101fe

feat: made fullname editable and updated design

5d8fe8a

eemaanamir requested a review from a team as a code owner May 21, 2025 13:21

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 21, 2025

openedx-webhooks added this to Aperture-Maintained and Contributions May 21, 2025

github-project-automation bot moved this to Needs Triage in Contributions May 21, 2025

test: updated test cases

449718b

sundasnoreen12 requested changes May 26, 2025

View reviewed changes

awais-ansari requested changes May 26, 2025

View reviewed changes

mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions May 27, 2025

feat: made profile editable #1212

Are you sure you want to change the base?

feat: made profile editable #1212

Uh oh!

Conversation

eemaanamir commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Key Changes:

Uh oh!

openedx-webhooks commented May 21, 2025

Uh oh!

codecov bot commented May 22, 2025

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eemaanamir commented May 21, 2025 •

edited

Loading