-
Notifications
You must be signed in to change notification settings - Fork 126
feat: avoid pulling entire lodash library into build #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Importing from lodash was causing the entire library to be pulled. This change reduces the compressed production build size of frontend-app-profile by 6kB.
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 5 5
Lines 57 57
Branches 19 19
=======================================
Hits 52 52
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not sure if I'd consider this a fix
or a feat
but either way it's a good change.
Thanks for noticing and PRing!
Thanks for the quick feedback Brian! If you're interested, I've listed a bunch of similar improvements here: openedx/wg-frontend#184 |
@regisb thanks for making the list! openedx/wg-frontend#184 seems like a good thing to bring up at a Frontend WG meeting, I'll post in the slack channel recommending it as a topic for next week's meeting! |
Importing from lodash was causing the entire library to be pulled. This change reduces the compressed production build size of frontend-app-profile by 6kB.