Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release-22.x to release-23.x #3415

Open
wants to merge 3 commits into
base: release-23.x
Choose a base branch
from

Conversation

brian-smith-tcril
Copy link
Contributor

#3403 with conflicts resolved

adamstankiewicz and others added 3 commits January 31, 2025 08:09
… use of Pagination component (openedx#3406)

This commit fixes a bug with the TablePagination component. This component renders the Pagination component without a paginationLabel prop, which is a required prop of the Pagination component. This commit adds a paginationLabel="table pagination" prop, which matches the prop passed to the PaginationComponent by the TablePaginationMinimal component.

Authored-by: michaelroytman <[email protected]>
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for paragon-openedx-v23 ready!

Name Link
🔨 Latest commit 1d64636
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v23/deploys/67a4cd8e2c2a2500087551c6
😎 Deploy Preview https://deploy-preview-3415--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.86%. Comparing base (e4ccd26) to head (1d64636).
Report is 4 commits behind head on release-23.x.

Files with missing lines Patch % Lines
src/Hyperlink/index.tsx 78.94% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #3415      +/-   ##
================================================
- Coverage         93.91%   93.86%   -0.06%     
================================================
  Files               232      233       +1     
  Lines              3943     3958      +15     
  Branches            901      939      +38     
================================================
+ Hits               3703     3715      +12     
+ Misses              236      235       -1     
- Partials              4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants