-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: release-22.x to release-23.x #3415
base: release-23.x
Are you sure you want to change the base?
sync: release-22.x to release-23.x #3415
Conversation
… use of Pagination component (openedx#3406) This commit fixes a bug with the TablePagination component. This component renders the Pagination component without a paginationLabel prop, which is a required prop of the Pagination component. This commit adds a paginationLabel="table pagination" prop, which matches the prop passed to the PaginationComponent by the TablePaginationMinimal component. Authored-by: michaelroytman <[email protected]>
✅ Deploy Preview for paragon-openedx-v23 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3415 +/- ##
================================================
- Coverage 93.91% 93.86% -0.06%
================================================
Files 232 233 +1
Lines 3943 3958 +15
Branches 901 939 +38
================================================
+ Hits 3703 3715 +12
+ Misses 236 235 -1
- Partials 4 8 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#3403 with conflicts resolved