Skip to content

fix: remove docker-compose attribute version #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove docker-compose attribute version #420

wants to merge 1 commit into from

Conversation

stephenwaite
Copy link
Member

hi @jesdynf, hopefully this doesn't disturb anything with the custom docker-compose in the lightsail packages. Guess I can test that out :)

Fixes #419

Short description of what this resolves:

Changes proposed in this pull request:

kojiromike
kojiromike approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@kojiromike kojiromike left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever my opinion's worth, I think this is a good change.

@msummers42
Copy link
Contributor

msummers42 commented Apr 30, 2025 •
edited
Loading

I support this change as well.

@bradymiller
Copy link
Member

ok with this as long as @jesdynf is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradymiller bradymiller bradymiller approved these changes

@kojiromike kojiromike kojiromike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: docker-compose: attribute version is obsolete
4 participants
@stephenwaite @msummers42 @bradymiller @kojiromike