-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove store ID from API config, allow override per-request #101
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 22.54% 23.53% +0.98%
==========================================
Files 94 95 +1
Lines 9754 9948 +194
==========================================
+ Hits 2199 2341 +142
- Misses 7304 7357 +53
+ Partials 251 250 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Changes in general look good, just the one callout where we're dropping #93 as it wasn't backported. Maybe we can merge openfga/sdk-generator/pull/365 and regenerate these changes?
Removes
StoreId
fromapi_open_fga.go
configuration, and enables per-request override of theStoreId
.Description
Removes the
StoreId
from the API client, and instead accept theStoreId
as a parameter. As discussed in #118, this allows for the removal of the custom patch during SDK generation.If using api_open_fga.go directly, you will now need to pass the StoreId parameter.
This change also enables per-request override of the
StoreId
, via the associated request's options.References
StoreId
from theOpenFgaApi
configuration interface sdk-generator#118Review Checklist
main