Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not ignore request level storeId in non-transactional write #162

Conversation

preiter93
Copy link
Contributor

Fix: Do not ignore request level storeId override in non-transactional write

Description

Currently, the request level store ID is ignored in non-transactional write requests, resulting in the error "storeId is required and must be specified". This PR fixes the issue by passing the storeId to the WriteExecute call.

This PR

  • passes the request level storeId to the WriteExecute call
  • extends the unit test covering the storeId override case

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@preiter93 preiter93 requested a review from a team as a code owner January 24, 2025 12:54
Copy link

linux-foundation-easycla bot commented Jan 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: preiter93 / name: Philipp Reiter (ef65e73)

@preiter93 preiter93 force-pushed the fix/non-transactional-write-store-id-overwrite branch from f99d0c3 to ef65e73 Compare January 24, 2025 17:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.71%. Comparing base (9b6f886) to head (ef65e73).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   25.68%   25.71%   +0.02%     
==========================================
  Files         104      104              
  Lines       12577    12582       +5     
==========================================
+ Hits         3231     3236       +5     
  Misses       9075     9075              
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @preiter93!

@ewanharris ewanharris added this pull request to the merge queue Jan 27, 2025
Merged via the queue into openfga:main with commit f0ce7d8 Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants