Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): add headers for Write/BatchCheck/ListRelations, add header overriding to client #37

Merged
merged 6 commits into from
Dec 15, 2023
Merged

feat(client): add headers for Write/BatchCheck/ListRelations, add header overriding to client #37

merged 6 commits into from
Dec 15, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Dec 12, 2023 •
edited
Loading

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper mentioned this pull request Dec 12, 2023
Merged
4 tasks
@rhamzeh
Copy link
Member

rhamzeh commented Dec 13, 2023

Also I didn't confirm, but if we haven't done that yet, User-Agent can be overridden by passing in something different as a default header or header override

See: https://github.com/openfga/go-sdk/blob/main/api_client.go#L278

@booniepepper
Copy link
Contributor Author

Looks like the User-Agent header was not handled yet. Adding this along with other feedback changes shortly

@booniepepper booniepepper marked this pull request as ready for review December 13, 2023 23:48
@booniepepper booniepepper requested a review from a team as a code owner December 13, 2023 23:48
@booniepepper booniepepper requested a review from rhamzeh December 14, 2023 00:41
adriantam
adriantam previously approved these changes Dec 14, 2023
View reviewed changes
@booniepepper booniepepper requested a review from rhamzeh December 14, 2023 19:37
rhamzeh
rhamzeh previously approved these changes Dec 14, 2023
View reviewed changes
@booniepepper booniepepper dismissed stale reviews from rhamzeh and adriantam via cc9f9df December 14, 2023 21:35
@booniepepper booniepepper force-pushed the headers-options-configs branch from 559f80c to cc9f9df Compare December 14, 2023 21:35
@rhamzeh rhamzeh added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 6614bf1 Dec 15, 2023
14 checks passed
@rhamzeh rhamzeh deleted the headers-options-configs branch December 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@adriantam adriantam adriantam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@booniepepper @rhamzeh @adriantam