Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: abstract common functionality & update validation exceptions #38

Merged
merged 3 commits into from
Dec 15, 2023
Merged

refactor: abstract common functionality & update validation exceptions #38

merged 3 commits into from
Dec 15, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Dec 15, 2023 •
edited
Loading

Description

  • refactor: use common functions in OpenFgaApi
  • refactor: update some validation exceptions

References

Generated by openfga/sdk-generator#253

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@booniepepper booniepepper mentioned this pull request Dec 15, 2023
Merged
4 tasks
@booniepepper booniepepper changed the title refactor: use common functions in OpenFgaApi, update some validation exception types refactor: use common functions in OpenFgaApi, update some validation exceptions Dec 15, 2023
Base automatically changed from headers-options-configs to main December 15, 2023 15:01
@booniepepper booniepepper marked this pull request as ready for review December 15, 2023 17:26
@booniepepper booniepepper requested a review from a team as a code owner December 15, 2023 17:26
@rhamzeh rhamzeh changed the title refactor: use common functions in OpenFgaApi, update some validation exceptions refactor: abstract common functionality & update validation exceptions Dec 15, 2023
rhamzeh
rhamzeh reviewed Dec 15, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rhamzeh rhamzeh enabled auto-merge December 15, 2023 21:05
@rhamzeh rhamzeh added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit d56e15a Dec 15, 2023
18 checks passed
@rhamzeh rhamzeh deleted the java/api-refactor branch December 15, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booniepepper @rhamzeh