Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes #141

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Sync changes #141

merged 3 commits into from
Oct 25, 2024

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Oct 25, 2024

Description

Syncs changes from the generator repo and also updates some generated files that got missed

References

openfga/sdk-generator#434
openfga/sdk-generator#422
openfga/sdk-generator#424

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

Sorry, something went wrong.

@ewanharris ewanharris requested review from a team as code owners October 25, 2024 16:34
@ewanharris
Copy link
Member Author

ewanharris commented Oct 25, 2024

Seems like sdk-generator doesn't fail if the tests fail. Reproduced locally, make test-client-python exits with 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (fe3af43) to head (b51370d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files         122      122           
  Lines        9771     9771           
=======================================
  Hits         6759     6759           
  Misses       3012     3012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 64d19e0 Oct 25, 2024
17 checks passed
@ewanharris ewanharris deleted the chore/port-updates branch October 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants