Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Product page redesign #6356

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PrimaelQuemerais
Copy link
Member

What

This PR introduces a new the layout for the product page (WIP)

Knowledge panels are now grouped in tabs which can be toggled and reordered.

Remaining tasks

  • Move reorder button to the end of the TabBar (instead of "For me" tab)
  • Save customizations locally (suggestions are welcome, how to conciliate hardcoded tabs and knowledge panel tabs)
  • Try to merge new generic reorder_bottom_sheet with ProductFooterSettings sheet
  • Implement UI elements from POC such as TabBar scroll hints, or border radius on selected tab indicator
  • Add ability to hide tabs

Screenshot

Simulator Screenshot - iPhone 16 Pro Max - 2025-01-21 at 15 40 42

Part of

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 249 lines in your changes missing coverage. Please review.

Project coverage is 5.82%. Comparing base (4d9c7fc) to head (6573199).
Report is 748 commits behind head on develop.

Files with missing lines Patch % Lines
...product/product_page/header/product_page_tabs.dart 0.00% 95 Missing ⚠️
...duct/product_page/header/reorder_bottom_sheet.dart 0.00% 71 Missing ⚠️
...b/pages/product/product_page/new_product_page.dart 0.00% 69 Missing ⚠️
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% 6 Missing ⚠️
.../lib/data_models/preferences/user_preferences.dart 0.00% 5 Missing ⚠️
...generic_lib/bottom_sheets/smooth_bottom_sheet.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6356      +/-   ##
==========================================
- Coverage     9.54%   5.82%   -3.73%     
==========================================
  Files          325     481     +156     
  Lines        16411   28938   +12527     
==========================================
+ Hits          1567    1686     +119     
- Misses       14844   27252   +12408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

2 participants