Skip to content

Commit

Permalink
🔧(docker) upgrade node images to latest 18 version
Browse files Browse the repository at this point in the history
Upgrade all node images to use the latest 18 version.
  • Loading branch information
jbpenrath committed Oct 24, 2024
1 parent f5a275c commit 5a4f914
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 13 deletions.
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ jobs:
# ---- mail jobs ----
build-mails:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
# ---- frontend admin jobs ----
build-test-front-admin:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand Down Expand Up @@ -323,7 +323,7 @@ jobs:

lint-front-admin:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand All @@ -341,7 +341,7 @@ jobs:

test-front-admin:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand All @@ -362,7 +362,7 @@ jobs:

test-e2e-front-admin:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand Down Expand Up @@ -390,7 +390,7 @@ jobs:

test-playwright-ct-front-admin:
docker:
- image: cimg/node:18.18
- image: cimg/node:18.20
auth:
username: $DOCKER_HUB_USER
password: $DOCKER_HUB_PASSWORD
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN mkdir /install && \


# ---- mails ----
FROM node:16 AS mail-builder
FROM node:18.20-slim AS mail-builder

COPY ./src/mail /mail/app

Expand Down
5 changes: 1 addition & 4 deletions docker/images/admin/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.19-slim as builder
FROM node:18.20-slim as builder

WORKDIR /app

Expand All @@ -14,6 +14,3 @@ FROM nginxinc/nginx-unprivileged:1.25 as production

COPY docker/files/admin/etc/nginx/conf.d/default.conf /etc/nginx/conf.d/default.conf
COPY --from=builder /app/out /app/admin



2 changes: 1 addition & 1 deletion src/frontend/admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,6 @@
"workerDirectory": "public"
},
"volta": {
"node": "18.18.2"
"node": "18.20.4"
}
}
2 changes: 1 addition & 1 deletion src/mail/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"build": "yarn build-mjml-to-html; yarn build-html-to-plain-text;"
},
"volta": {
"node": "16.15.1"
"node": "18.20.4"
},
"repository": "https://github.com/openfun/joanie",
"author": "France Université Numérique",
Expand Down

0 comments on commit 5a4f914

Please sign in to comment.