WIP✨(backend) add bulk delete route #346

samy-aitouakli · 2023-07-12T07:30:57Z

Add route to admin api to bulk delete objects

src/backend/joanie/tests/core/test_api_admin_certificate_definitions.py

src/backend/joanie/core/api/admin.py

src/backend/joanie/core/mixins/admin.py

src/backend/joanie/tests/core/test_api_admin_course_runs.py

src/backend/joanie/tests/core/test_api_admin_organizations.py

src/backend/joanie/tests/core/test_api_admin_products.py

sampaccoud · 2023-07-25T17:51:42Z

I would have found it more coherent with our other endpoints to pass the ids to delete as a required query string filter.
you do not check that the admin user has delete rights on this type of object. This is something your tests should take care of!

Add route to admin api to bulk delete objects

jbpenrath · 2023-08-01T08:29:23Z

This PR has been adjourned as bulk delete is not trivial at all as :

We should check user rights to delete or not the resource
It implies to write a custom mixin with a non standard response

At first, frontend admin could use a cascade of unique delete requests. Then we could imagine a soft delete logic.

samy-aitouakli self-assigned this Jul 12, 2023

samy-aitouakli requested review from sampaccoud, jbpenrath and jonathanreveille July 12, 2023 07:35

samy-aitouakli force-pushed the saitouakli/bulk_delete branch from cd4f2af to 06bf7b9 Compare July 12, 2023 13:14

jbpenrath added the feature label Jul 17, 2023

jbpenrath reviewed Jul 18, 2023

View reviewed changes

src/backend/joanie/tests/core/test_api_admin_certificate_definitions.py Show resolved Hide resolved

src/backend/joanie/core/api/admin.py Outdated Show resolved Hide resolved

src/backend/joanie/core/api/admin.py Outdated Show resolved Hide resolved

samy-aitouakli force-pushed the saitouakli/bulk_delete branch 3 times, most recently from c4fbcc0 to 8a81d16 Compare July 21, 2023 07:42

jbpenrath reviewed Jul 21, 2023

View reviewed changes

src/backend/joanie/core/mixins/admin.py Outdated Show resolved Hide resolved

jonathanreveille reviewed Jul 21, 2023

View reviewed changes

src/backend/joanie/tests/core/test_api_admin_course_runs.py Outdated Show resolved Hide resolved

src/backend/joanie/tests/core/test_api_admin_organizations.py Show resolved Hide resolved

src/backend/joanie/tests/core/test_api_admin_products.py Show resolved Hide resolved

samy-aitouakli force-pushed the saitouakli/bulk_delete branch 5 times, most recently from 2cd1f31 to b825de9 Compare July 24, 2023 16:59

samy-aitouakli changed the title ~~✨(backend) add bulk delete route~~ WIP✨(backend) add bulk delete route Jul 25, 2023

samy-aitouakli removed the request for review from sampaccoud July 25, 2023 15:18

samy-aitouakli force-pushed the saitouakli/bulk_delete branch from b825de9 to 7db2e23 Compare July 31, 2023 16:30

✨(backend) add bulk delete route

3ab3572

Add route to admin api to bulk delete objects

samy-aitouakli force-pushed the saitouakli/bulk_delete branch from 7db2e23 to 3ab3572 Compare July 31, 2023 16:36

f

1d1ca17

samy-aitouakli removed their assignment Aug 1, 2023

jbpenrath assigned samy-aitouakli Aug 16, 2023

jbpenrath marked this pull request as draft August 16, 2023 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP✨(backend) add bulk delete route #346

WIP✨(backend) add bulk delete route #346

samy-aitouakli commented Jul 12, 2023

sampaccoud commented Jul 25, 2023

jbpenrath commented Aug 1, 2023

WIP✨(backend) add bulk delete route #346

Are you sure you want to change the base?

WIP✨(backend) add bulk delete route #346

Conversation

samy-aitouakli commented Jul 12, 2023

sampaccoud commented Jul 25, 2023

jbpenrath commented Aug 1, 2023