✨ replace grommet select by cunningham select #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
changed the base branch from
master
to
feature/anthony/cunningham-text-input
AntoLC
force-pushed
the
feature/anthony/cunningham-text-input
branch
from
ae0fbba to
1709ed1
Compare
Base automatically changed from
feature/anthony/cunningham-text-input
to
master
September 7, 2023 09:03
AntoLC
force-pushed
the
feature/anthony/cunningham-select
branch
12 times, most recently
from
667e22f to
257f4b6
Compare
|
We need this issue to be resolved with a new cunningham version before we can merge this PR. A PR has been submitted: openfun/cunningham#158, when merge and release we will be able to adapt this PR to be mergeable. |
AntoLC
force-pushed
the
feature/anthony/cunningham-select
branch
2 times, most recently
from
8a7b920 to
f98a6e7
Compare
kernicPanel
reviewed
Sep 11, 2023
...ndalone_site/src/features/Contents/features/Video/components/Manage/VideoCreateForm.spec.tsx
Show resolved
Hide resolved
...ackages/lib_video/src/components/common/VideoWidgetProvider/widgets/LicenseManager/index.tsx
Outdated
Show resolved
Hide resolved
AntoLC
force-pushed
the
feature/anthony/cunningham-select
branch
2 times, most recently
from
ced6a4d to
8e92bff
Compare
kernicPanel
approved these changes
Sep 12, 2023
lunika
reviewed
Sep 12, 2023
| @@ -98,14 +105,19 @@ export const LanguageSelect = ({ | |||
| return ( | |||
| <Select | |||
There was a problem hiding this comment.
Can the list be longer? Only 4 countries are display and the list is very long. In master branch 8 are display.
There was a problem hiding this comment.
As talked, the select is now searchable: 0449192
On the other hand now, if french is set in the value by example, when you click on the select, only one option will be proposed; you will have to clear the field to see more options appearing.
|
The translations in french have to be review, maybe I should change the When english language is set: When french language is set: |
I will do that on crowdin 👍 |
lunika
approved these changes
Sep 13, 2023
AntoLC
force-pushed
the
feature/anthony/cunningham-select
branch
3 times, most recently
from
7c291c9 to
363bd08
Compare
Upgrade to [email protected], this upgrade fixes these issues: - openfun/cunningham#149 - openfun/cunningham#157
- replace the Grommet Select component with the Cunningham Select component
We had some states flipping with the LanguageSelect component with "no language available" option. The no language available option was selectable, and would create an error in the upload process if selected. We remove the "no language available" option, and let the Cunningham component handle the case when no options are available.
AntoLC
force-pushed
the
feature/anthony/cunningham-select
branch
from
363bd08 to
51cd65b
Compare
lunika
added a commit
that referenced
this pull request
Sep 15, 2023
Changed - Disable classroom convert button when converting - Replace grommet Select by Cunningham Select (#2400) Fixed - Save license when a video is created - Show an error when a resource has been deleted - Allow depositedfiles to have unicode characters in their filename
lunika
added a commit
that referenced
this pull request
Sep 18, 2023
Changed - Disable classroom convert button when converting - Replace grommet Select by Cunningham Select (#2400) Fixed - Save license when a video is created - Show an error when a resource has been deleted - Allow depositedfiles to have unicode characters in their filename
lunika
added a commit
that referenced
this pull request
Sep 18, 2023
Changed - Disable classroom convert button when converting - Replace grommet Select by Cunningham Select (#2400) Fixed - Save license when a video is created - Show an error when a resource has been deleted - Allow depositedfiles to have unicode characters in their filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace partially grommet select by cunningham select.
The Cunnigham Select doesn't fit all our needs, but we can still replace a part of the select.
This PR helps us as well to identify our different needs, an feature request issue has been opened alongside this PR: openfun/cunningham#155
Proposal
Selectby cunninghamSelectSelect left
. LanguagePicker : We need an icon on the left of the select.
. useSelectPlaylist: We need the virtualization - We can have lot of playlist
. RenaterAuthenticator: We need options with
JSX.Element[]type. SchedulingFields: We need
suggestionprop, to start the scroll to a specific value andsearchableFreeprop, to search a potential value but let as well the possibility to use the value taped by the user (see example)