🐛(dogwood/3/fun) pin django-classy-tags version to 0.8.0
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
approved these changes
Sep 8, 2020
|
@madmatah I think the other flavors will have the same problem!? |
Thanks ! I checked after your comment : On Hawthorn :It seems to be OK because On Eucalyptus :The installed version is 2.0.0 and need to be pinned, yep. |
|
So should we pin it to 0.8 instead if that's what Hawthorn is running on!? |
@sampaccoud Yes we can do that to be sure. |
jmaupetit
approved these changes
Sep 8, 2020
madmatah
force-pushed
the
dogwood-fun-pin-classy-tags
branch
from
7ca6ccb to
f164c84
Compare
sampaccoud
changed the title
django-classy-tags version to 1.0.0django-classy-tags version to 0.8.0
`django-classy-tags` 2.0.0 dropped support for python 2.x. As a result, we get fatal errors in our recent builds. We pin it to version 0.8.0 because that's the version used in hawthorn base requirements.
Fixed - Pin django-classy-tags to 1.0.0 to avoid breaking changes in 2.0.0
`django-classy-tags` 2.0.0 dropped support for python 2.x. As a result, we get fatal errors in our recent builds. We pin it to version 0.8.0 because that's the version used in hawthorn base requirements.
Fixed - Pin django-classy-tags to 0.8.0 to avoid breaking changes
madmatah
force-pushed
the
dogwood-fun-pin-classy-tags
branch
from
f164c84 to
7b2fea5
Compare
|
Done! I'm ready for a final review if the CI checks pass 🙂 |
|
@madmatah are the |
sampaccoud
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Recent builds of dogwood.3-fun install
django-classy-tags2.0.0, that is not compatible anymore with python 2.x.Same problem with eucalyptus flavor.
Proposal
django-classy-tagsversion to 0.8.0