🏗️(backends) migrate LRSHTTPBackend to LRSDataBackend #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioSim
force-pushed
the
unify-http-backends
branch
2 times, most recently
from
da71183 to
aad886a
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
a80bb8d to
c00b87c
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
aad886a to
22699e6
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
c00b87c to
04046d1
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
2 times, most recently
from
68875b0 to
7fe00fb
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
b582a00 to
1e9bd8c
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
7fe00fb to
eb756f1
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
1e9bd8c to
6b646dc
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
eb756f1 to
7c565f1
Compare
wilbrdt
reviewed
Nov 28, 2023
There was a problem hiding this comment.
We should also update the documentation for the LRS HTTP backends (even if it's not mature yet, we reference it here https://openfun.github.io/ralph/master/backends/#learning_record_store_lrs_-_http_backend_interface)
SergioSim
force-pushed
the
add-greedy-option
branch
from
6b646dc to
34bd639
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
7c565f1 to
5db2377
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
0e49ffb to
35c33f2
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
5db2377 to
5b89b09
Compare
Leobouloc
approved these changes
Dec 5, 2023
SergioSim
force-pushed
the
add-greedy-option
branch
from
35c33f2 to
399c070
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
5b89b09 to
5bbd28b
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
2 times, most recently
from
b550933 to
6956c70
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
d342c4c to
5fe4fe3
Compare
SergioSim
force-pushed
the
add-greedy-option
branch
from
d5fa232 to
88c0868
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
5fe4fe3 to
cf3899d
Compare
Good point) Thanks) Moved the documentation update related to the LRS data backend made in the WebSocket PR here) |
wilbrdt
approved these changes
Dec 11, 2023
SergioSim
force-pushed
the
add-greedy-option
branch
2 times, most recently
from
8332dc7 to
a316f0d
Compare
SergioSim
force-pushed
the
unify-http-backends
branch
from
b3c2803 to
94a9650
Compare
The interface of the http backends are now very similar to the data backends. Thus, to limit redundant interfaces we opt to move the LRSHTTPBackend and AsyncLRSHTTPBackend to the data backend package. We also update the cli write command to align more with the data backend interface. Moreover, the LRSDataBackend no longer inherits from the AsyncLRSDataBackend to alow it's usage in an async context. Finally, the behavior of the sync and async versions of the lrs data backend are very similar. Thus, to keep both implementations inline, we tests both of them in the same file.
SergioSim
force-pushed
the
unify-http-backends
branch
from
94a9650 to
6a3a517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The interface of the http backends are now very similar to the data backends.
We want to limit the number of backend interfaces.
Proposal
AsyncLRSDataBackendandLRSDataBackend