✨(frontend) dashboard teacher: page profile courses #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
3 times, most recently
from
5f25a8f to
22b9ec7
Compare
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
from
22b9ec7 to
fb0d2ac
Compare
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
2 times, most recently
from
678e1de to
88c4ec6
Compare
jbpenrath
reviewed
Apr 5, 2023
src/frontend/js/widgets/Dashboard/components/TeacherCourseSearchFilters/_styles.scss
Show resolved
Hide resolved
src/frontend/js/widgets/Dashboard/components/TeacherCourseSearchFilters/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/js/widgets/Dashboard/components/TeacherCourseSearchFilters/index.tsx
Show resolved
Hide resolved
src/frontend/js/widgets/Dashboard/components/TeacherCourseSearchFilters/index.tsx
Outdated
Show resolved
Hide resolved
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
8 times, most recently
from
6bc9958 to
185555d
Compare
rlecellier
changed the title
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
2 times, most recently
from
14aa15b to
a9e52c8
Compare
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
2 times, most recently
from
d0574c7 to
cfab391
Compare
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
2 times, most recently
from
1672b03 to
207ddb5
Compare
jbpenrath
reviewed
Apr 21, 2023
src/frontend/js/widgets/Dashboard/components/DashboardItem/stories.mock.ts
Outdated
Show resolved
Hide resolved
|
Great work ! Just a general feeback : for next reviews, try to split our changes into smaller commit, this PR was a bit hard to review 💊 |
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
from
207ddb5 to
e1f0a53
Compare
rlecellier
commented
Apr 24, 2023
src/frontend/js/widgets/Dashboard/components/DashboardItem/stories.mock.ts
Outdated
Show resolved
Hide resolved
jbpenrath
reviewed
Apr 24, 2023
We need Course to contain lot's more information for our course endpoint that will be make for teacher dashboard course page.
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
from
e1f0a53 to
326c1f7
Compare
jbpenrath
reviewed
Apr 27, 2023
Comment on lines
+43
to
+44
| status: CourseStatusFilter; | ||
| type: CourseTypeFilter; |
There was a problem hiding this comment.
As is, we always have a filter value with "all" instead of undefined for all the results
| </span> | ||
| </Spinner> | ||
| )} | ||
| {!fetching && courses.length && ( |
There was a problem hiding this comment.
Currently, if courses array is empty, 0 will be displayed.
Suggested change
| {!fetching && courses.length && ( | |
| {!fetching && courses.length > 0 && ( |
There was a problem hiding this comment.
I think a test is missing to check what happens when courses is empty.
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
2 times, most recently
from
d9335e9 to
b6a0e73
Compare
Part of teacher dashboard development, list teacher courses.
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_courses
branch
from
b6a0e73 to
a56f322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add course search page for teacher profile in new teacher dashboard.
Sketch preview
Proposal
Joanie.CourseintoJoanie.CourseLightJoanie.Courseused in Teacher Dashboard listingsCourseGlimpseandCourseGlimpseListin newTeacherDashboardCoursepage.TeacherDashboardCoursepage.Todo
Backend filters for courses
Date manipulation
it would be nice to have a library to handle date transformations and formating.
The one used on my previous project was date-fns.