Add new fields and sections to the Program detail page #2557
Conversation
Add effort, duration, price, team, objectives and other optional fields.
|
Hi @jbpenrath, can you give me some feedback on this or assign someone to help me review this and improve it? |
|
There are a couple of tasks not yet complete or dependent on other NAU teams PR, like the currency type, that should be a setting and not an hardcoded value. |
| @@ -54,6 +55,79 @@ | |||
| padding-right: $grid-gutter-width; | |||
| } | |||
|
|
|||
| &__objectives { | |||
| @if r-theme-val(program-detail, checkmark-list-decoration) { | |||
There was a problem hiding this comment.
This statement is useless, as you defined checkmark-list-decoration into _theme.scss, it will be always defined.
| } | ||
| } | ||
|
|
||
| @if $r-program-aside { |
There was a problem hiding this comment.
Ditto. This statement is useless.
| <symbol id="icon-money" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" fill="none" stroke-width="1.5" stroke="currentColor"> | ||
| <path stroke-linecap="round" stroke-linejoin="round" d="M2.25 18.75a60.07 60.07 0 0 1 15.797 2.101c.727.198 1.453-.342 1.453-1.096V18.75M3.75 4.5v.75A.75.75 0 0 1 3 6h-.75m0 0v-.375c0-.621.504-1.125 1.125-1.125H20.25M2.25 6v9m18-10.5v.75c0 .414.336.75.75.75h.75m-1.5-1.5h.375c.621 0 1.125.504 1.125 1.125v9.75c0 .621-.504 1.125-1.125 1.125h-.375m1.5-1.5H21a.75.75 0 0 0-.75.75v.75m0 0H3.75m0 0h-.375a1.125 1.125 0 0 1-1.125-1.125V15m1.5 1.5v-.75A.75.75 0 0 0 3 15h-.75M15 10.5a3 3 0 1 1-6 0 3 3 0 0 1 6 0Zm3 0h.008v.008H18V10.5Zm-12 0h.008v.008H6V10.5Z" /> | ||
| </symbol> | ||
|
|
||
| <symbol id="icon-courses" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg" fill="none" stroke-width="1.5" stroke="currentColor"> | ||
| <path stroke-linecap="round" stroke-linejoin="round" d="M19.5 14.25v-2.625a3.375 3.375 0 0 0-3.375-3.375h-1.5A1.125 1.125 0 0 1 13.5 7.125v-1.5a3.375 3.375 0 0 0-3.375-3.375H8.25m0 12.75h7.5m-7.5 3H12M10.5 2.25H5.625c-.621 0-1.125.504-1.125 1.125v17.25c0 .621.504 1.125 1.125 1.125h12.75c.621 0 1.125-.504 1.125-1.125V11.25a9 9 0 0 0-9-9Z" /> |
There was a problem hiding this comment.
Can you please update the IconEnum in the frontend to add those two new icons.
There was a problem hiding this comment.
Of course. Will do.
So your idea is to aggregate this information via courses without creating new manual fields. Do you think it would make sense to be able to manually override? I'm just trying to cover all the bases, due to the different typologies of programs we can have. |
It depends to your need. Concerning Editor UX and data consistency, It looks great to aggregate those data from related courses but if you know that those information will need to be overridden, I think your current implementation fullfil the need, is simpler so that's the best. |
There was a problem hiding this comment.
About the new placeholder. On the publish page, I'll display anything if there is no content. e.g: Currently, if no organization is set, a text telling there is no organization is displayed.
There was a problem hiding this comment.
Check that. I'll make sure everything is sane before putting this up as a PR. Thanks for the observation
Add effort, duration, price, team, objectives and other optional fields.
Purpose
As described in #2556, this PR adds new fields to the programs page and information disposition, much closer to the course detail template.
This allows for a better grasp on all the information related to the program.