🐛(backend) skip hidden course runs from state calculation #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiago-Salles
changed the title
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/281-hidden-course-org-pages
branch
from
b178a98 to
c8aba33
Compare
- On the state property skip the hidden ones
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/281-hidden-course-org-pages
branch
from
c8aba33 to
6b869dc
Compare
igobranco
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM ✔️
@jbpenrath this looks good for me, but I think someone from FUN should also review this PR before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug of state calculation for related courses. On the state property skip course runs with
catalog_visibilityas hidden.Purpose
We at NAU idenfied a bug related to the course run state calculation.
As it is possible to see, the following course presents Feb 2025 as the start, but this course is hidden. This happens on all the pages that show related courses.
Organization detail page
Course page
Course search
Course page on edit mode
Conclusion
The sequence of images shows that, in the course search page the behavior is as expected, it does not show hidden courses, but when it comes to showing related courses, the hidden ones are being considered. This PR excludes from the query the hidden ones, without impacting on the other places that list course runs, such as in the course page admin.