🔧(helm) multiple changes for deploying with stack
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wilbrdt
changed the title
stack
wilbrdt
force-pushed
the
helm/tweaks
branch
3 times, most recently
from
c8c9f75 to
8986e5d
Compare
Helm template files naming generally follows the kebab-case naming convention. Renaming Warren helm template files to follow it.
Now that we use Hashicorp Vault for managing secrets, we can now create secrets to store sensitive environment variables within the chart. Additionally, non-sensitive environment variables are now appropriately segregated withing configmaps (api/app env, database and logging).
On liveness and readiness probes, with virtual hosts, `Host` should be set in the Host header. As the default value is an empty list, Helm linter was raising an error. Fixing the lint issue by only adding an `httpHeaders` if value `allowHosts` is not empty, for both `api` and `app` deployments.
As it is generally recommended to handle databases outside the cluster, disabling the postgresql database deployment by default.
|
Closing as work is done on #252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Naming convention
Secrets and configmaps
Minor lint issue
httpHeadersif valueallowHostsis not empty, for bothapiandappdeployments.Migration and staticfiles collection jobs
initContainerinside the deployment, either executing the migration/collection, or waiting for jobs doing the migration/collection.