Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(xi) add a xi command to index all courses and their content #258

Merged
merged 2 commits into from
Jun 3, 2024
Merged

✨(xi) add a xi command to index all courses and their content #258

merged 2 commits into from
Jun 3, 2024

Conversation

wilbrdt
Copy link
Contributor

@wilbrdt wilbrdt commented May 28, 2024

Proposal

Adding a useful warren xi index all command to index all courses of a LMS
instance, and their content.

@wilbrdt
🔊(xi) add possibility to ignore error when indexing courses
4f55dbb 
Validation errors that happens on course indexing were not ignored by the
`ignore_errors` flag.
Fixing it.
@wilbrdt wilbrdt requested a review from quitterie-lcs May 28, 2024 15:49
@wilbrdt wilbrdt self-assigned this May 28, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f16437d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

quitterie-lcs
quitterie-lcs reviewed May 30, 2024
View reviewed changes
src/api/core/warren/cli.py Outdated Show resolved Hide resolved
src/api/core/warren/cli.py Show resolved Hide resolved
@wilbrdt wilbrdt requested a review from quitterie-lcs June 3, 2024 08:36
quitterie-lcs
quitterie-lcs approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@quitterie-lcs quitterie-lcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but we should keep in mind improvements for later

@wilbrdt
✨(xi) add a xi command to index all courses and their content
f16437d 
Adding a useful `warren xi index all` command to index all courses of a LMS
instance, and their content.
@wilbrdt wilbrdt merged commit 79da1ac into main Jun 3, 2024
29 checks passed
@wilbrdt wilbrdt deleted the xi/index-all branch June 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quitterie-lcs quitterie-lcs quitterie-lcs approved these changes

Assignees

@wilbrdt wilbrdt

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilbrdt @quitterie-lcs