Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS client: Fix connection fails when using dev server #2980

Closed
wants to merge 1 commit into from

Conversation

florian-h05
Copy link
Contributor

Webpack Dev Server/http-proxy-middleware cannot handle our own pseudo websocket protocols used to send the access token.

Webpack Dev Server/http-proxy-middleware cannot handle our own pseudo websocket protocols used to send the access token.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from ghys as a code owner January 4, 2025 19:50
@florian-h05 florian-h05 changed the title WS client: Fix connection fails for dev server WS client: Fix connection fails when using dev server Jan 4, 2025
@florian-h05
Copy link
Contributor Author

@ghys FYI

Copy link

relativeci bot commented Jan 4, 2025

#2643 Bundle Size — 10.97MiB (~+0.01%).

2d75cc6(current) vs 75e8667 main#2642(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2643
     Baseline
#2642
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
No change  Cache Invalidation 17.33% 17.33%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2950 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.78% 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2643
     Baseline
#2642
Regression  JS 9.18MiB (~+0.01%) 9.18MiB
No change  CSS 866.3KiB 866.3KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:ws-client-devProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 marked this pull request as draft January 4, 2025 20:01
@florian-h05
Copy link
Contributor Author

Okay seems this was my fault and something was wrong with my dev installation of openHAB.

@florian-h05 florian-h05 closed this Jan 4, 2025
@florian-h05 florian-h05 deleted the ws-client-dev branch January 4, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant