Clean Up Outdated Files in Repo #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogu
approved these changes
Oct 4, 2024
|
@jogu what is your opinion on removing the diagrams directory? |
Sakurann
approved these changes
Oct 8, 2024
|
Editorial, 2 approvals -> merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a PR, I noticed that there are some files in the repo that don't seem to be maintained and contain potentially conflicting information to the spec. While they might be useful, maybe they are better hosted at a different location.
I was also wondering if we can outright remove https://github.com/openid/OpenID4VCI/tree/main/diagrams as those diagrams for example contain
c_noncereferences that will be removed after #381 is merged