-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for wallet attestation #408
Open
paulbastian
wants to merge
20
commits into
main
Choose a base branch
from
wallet-attestations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3fb4666
initial draft for wallet attestation
paulbastian 526a16c
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian 194b16e
examples for wallet attestation
paulbastian 7820bca
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian acccaef
add history
paulbastian 94676a9
Merge branch 'main' into wallet-attestations
paulbastian a3c93d2
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian 63daa67
Apply suggestions from Giuseppe
paulbastian 85cbd14
some minor changes on Torsten's review
paulbastian 3acc0e8
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian fc78c4a
Apply suggestions from code review
paulbastian 693197f
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian 699b7b6
Apply suggestions from code review
paulbastian d3858e0
Apply suggestions from code review
paulbastian e1391a9
Apply suggestions from code review
paulbastian e149a8c
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian e96f24b
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian c33c267
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian 9b1eb85
Update openid-4-verifiable-credential-issuance-1_0.md
paulbastian e7f7105
Apply suggestions from code review
paulbastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically the wallet attestation is a signed attestation that can be used in the client authentication mechanisms, as outlined in my previous comment.
if agreed, I can therefore purpose a rewording also here