Change note about SD-KWT KB JWT nonce/aud to be normative #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-pi
approved these changes
Dec 2, 2024
Sakurann
requested changes
Dec 3, 2024
nemqe
approved these changes
Dec 4, 2024
c2bo
approved these changes
Dec 9, 2024
paulbastian
approved these changes
Dec 9, 2024
Sakurann
approved these changes
Dec 10, 2024
Sakurann
reviewed
Dec 10, 2024
| - the `nonce` claim MUST be the value of `nonce` from the Authorization Request; | ||
| - the `aud` claim MUST be the value of the Client Identifier; | ||
|
|
||
| Note that for an unsigned Authorization Request over the DC API the `client_id` parameter is not used and the effective Client Identifier is derived from the origin received from the platform as described in (#dc_api_request). |
There was a problem hiding this comment.
Suggested change
| Note that for an unsigned Authorization Request over the DC API the `client_id` parameter is not used and the effective Client Identifier is derived from the origin received from the platform as described in (#dc_api_request). | |
| Note that for an unsigned Authorization Request over the DC API, the `client_id` parameter is not used, and the effective Client Identifier is derived from the origin received from the platform as described in (#dc_api_request). |
punctuation?
There was a problem hiding this comment.
Suggested change
| Note that for an unsigned Authorization Request over the DC API the `client_id` parameter is not used and the effective Client Identifier is derived from the origin received from the platform as described in (#dc_api_request). | |
| Note that for an unsigned Authorization Request over the DC API, the `client_id` parameter is not used. Instead, the effective Client Identifier is derived from the origin received from the platform, as described in section (#dc_api_request). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this was flagged as a note, it's the only place across SD-JWT/SD-JWT VC/OID4VP/HAIP that actually defines this behaviour. Also move it up a few paragraphs as it seems better to have all the normative text in this section together.
closes #350