Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPTIONAL/REQUIRED to the fields in the stream configuration #170

Merged
merged 1 commit into from
May 16, 2024

Conversation

FragLegs
Copy link
Contributor

Addresses Issue #141 . When we added description to the Stream Configuration we said that it was an optional field. That left open a question about whether the other fields were required or not. The descriptions on the fields make it clear that some of them should be optional. This PR makes it explicit which ones are optional and which are required.

@FragLegs FragLegs requested a review from a team as a code owner May 16, 2024 16:06
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tulshi tulshi merged commit 87a96eb into main May 16, 2024
2 checks passed
@tulshi tulshi deleted the 141-mark-stream-config-optional-required branch May 16, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants