Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHOULD language about checking the issuer value #172

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

FragLegs
Copy link
Contributor

To address the attack identified in Issue #162, we recommend that the Receiver SHOULD check the iss value when getting a Stream Configuration from the Transmitter to ensure that it matches the Issuer that sent the Transmitter Configuration data.

@FragLegs FragLegs requested a review from a team as a code owner May 23, 2024 16:00
Copy link
Contributor

@appsdesh appsdesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with this, the receivers MUST validate iss claims on every SSF event delivered on the stream

@FragLegs
Copy link
Contributor Author

Along with this, the receivers MUST validate iss claims on every SSF event delivered on the stream

@appsdesh I agree that Receivers ought to validate the iss claim in the SET, but is there a specific attack that you are imagining that can only be countered this way?

@FragLegs FragLegs linked an issue May 24, 2024 that may be closed by this pull request
@tulshi tulshi requested a review from timcappalli May 24, 2024 20:39
@timcappalli
Copy link
Member

Why is this a SHOULD vs a MUST?

@FragLegs
Copy link
Contributor Author

FragLegs commented May 26, 2024

Why is this a SHOULD vs a MUST?

@timcappalli I don't feel strongly about this, but the SSF spec is mostly concerned with what the Transmitter MUST do. It seems like we generally take a more lenient stance towards the Receiver. I think the underlying statement is, "If the Receiver doesn't want to be subjected to attacks a, b, and c, then it SHOULD do x, y, and z."

@FragLegs
Copy link
Contributor Author

FragLegs commented Jun 6, 2024

Note to self: also need to tie Issuer of metadata to iss

@FragLegs FragLegs merged commit 79bec1c into main Jun 10, 2024
2 checks passed
@FragLegs FragLegs deleted the 162-check-issuer branch June 10, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issuer Mix-Up
4 participants