-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC #24347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks @calvinccheung and @matias9927 for the review. |
Going to push as commit 6970cf6.
Your commit was automatically rebased without conflicts. |
Please review this small fix. When ZGC is enabled, heap dumping is disabled, so we should't call functions that are related to heap dumping.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24347/head:pull/24347
$ git checkout pull/24347
Update a local copy of the PR:
$ git checkout pull/24347
$ git pull https://git.openjdk.org/jdk.git pull/24347/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24347
View PR using the GUI difftool:
$ git pr show -t 24347
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24347.diff
Using Webrev
Link to Webrev Comment