Skip to content

8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC #24347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

iklam
Copy link
Member

@iklam iklam commented Apr 1, 2025

Please review this small fix. When ZGC is enabled, heap dumping is disabled, so we should't call functions that are related to heap dumping.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24347/head:pull/24347
$ git checkout pull/24347

Update a local copy of the PR:
$ git checkout pull/24347
$ git pull https://git.openjdk.org/jdk.git pull/24347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24347

View PR using the GUI difftool:
$ git pr show -t 24347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24347.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC

Reviewed-by: ccheung, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6891490: 8353324: Clean up of comments and import after 8319192
  • 07fd666: 8342984: Bump minimum boot jdk to JDK 24
  • 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
  • 19eabaf: 8353227: JFR: Prepare tests for strong parser validation
  • 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@iklam iklam changed the title 8352775: java -XX:AOTMode=create -XX:+UseZGC crashes 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC Apr 1, 2025
@iklam iklam marked this pull request as ready for review April 1, 2025 15:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2025

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2025
Copy link
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iklam
Copy link
Member Author

iklam commented Apr 1, 2025

Thanks @calvinccheung and @matias9927 for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2025

Going to push as commit 6970cf6.
Since your change was applied there have been 6 commits pushed to the master branch:

  • afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
  • 6891490: 8353324: Clean up of comments and import after 8319192
  • 07fd666: 8342984: Bump minimum boot jdk to JDK 24
  • 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
  • 19eabaf: 8353227: JFR: Prepare tests for strong parser validation
  • 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2025
@openjdk openjdk bot closed this Apr 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2025
@openjdk
Copy link

openjdk bot commented Apr 1, 2025

@iklam Pushed as commit 6970cf6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants