-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y #24583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@plummercj The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. Are you going to tweak more tests with this flag?
No. Only the one test needs includevirtualthreads=y. |
Don't use includevirtualthreads=y unless the test requires it. Debuggers don't usually use includevirtualthreads=y, so we should be doing most of our testing without it. The only reason tests use it is because some tests need it so they can find virtual threads in the debuggee by using vm.allThreads(). This change limits the use of includevirtualthreads=y to just those com/sun/jdi tests that need it.
Tested by running com/sun/jdi tests on all supported platforms in both platform threads mode and virtual threads mode. Also tested with tier1 CI.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24583/head:pull/24583
$ git checkout pull/24583
Update a local copy of the PR:
$ git checkout pull/24583
$ git pull https://git.openjdk.org/jdk.git pull/24583/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24583
View PR using the GUI difftool:
$ git pr show -t 24583
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24583.diff
Using Webrev
Link to Webrev Comment