Skip to content

8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y #24583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Apr 10, 2025

Don't use includevirtualthreads=y unless the test requires it. Debuggers don't usually use includevirtualthreads=y, so we should be doing most of our testing without it. The only reason tests use it is because some tests need it so they can find virtual threads in the debuggee by using vm.allThreads(). This change limits the use of includevirtualthreads=y to just those com/sun/jdi tests that need it.

Tested by running com/sun/jdi tests on all supported platforms in both platform threads mode and virtual threads mode. Also tested with tier1 CI.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24583/head:pull/24583
$ git checkout pull/24583

Update a local copy of the PR:
$ git checkout pull/24583
$ git pull https://git.openjdk.org/jdk.git pull/24583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24583

View PR using the GUI difftool:
$ git pr show -t 24583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24583.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8353953 8353953: con/sun/jdi tests should be fixed to not always require includevirtualthreads=y Apr 10, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2025
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 10, 2025

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. Are you going to tweak more tests with this flag?

@plummercj
Copy link
Contributor Author

This looks okay. Are you going to tweak more tests with this flag?

No. Only the one test needs includevirtualthreads=y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants