-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361255: CTW: Tolerate more NCDFE problems #26090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
Sanity-checking CTW times:
|
test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/Compiler.java
Outdated
Show resolved
Hide resolved
try { | ||
UNSAFE.ensureClassInitialized(aClass); | ||
} catch (NoClassDefFoundError e) { | ||
CompileTheWorld.OUT.printf("[%d]\t%s\tNOTE unable to init class : %s%n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean \n
here and in all other outputs? %n
needs local variable to store size of output.
We routinely CTW 3rd party JARs to make sure our compilers work. By the nature of the JARs, they have dependencies on other JARs, and CTW runner frequently warns out with NCDFE. It does so very crudely, missing opportunities to compile the methods that do not trigger NCDFEs. CTW should be made more tolerant to this. I think the normal "modules" CTW runs into the similar problem, but on a lesser scale, as we do not have a very hairy dependency graph within JDK.
The CTW logs are also fairly noisy with full exception traces when NCDFE is semi-expected. This PR does not print exception stack traces in these cases, only "NOTE"-s about it. This makes the log fairly clean and more understandable.
Motivational scope improvement compiling a sample 3rd party JAR (cassandra-2.1.4.0.jar):
Additional testing:
applications/ctw/modules
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26090/head:pull/26090
$ git checkout pull/26090
Update a local copy of the PR:
$ git checkout pull/26090
$ git pull https://git.openjdk.org/jdk.git pull/26090/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26090
View PR using the GUI difftool:
$ git pr show -t 26090
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26090.diff
Using Webrev
Link to Webrev Comment