Skip to content

8361255: CTW: Tolerate more NCDFE problems #26090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 2, 2025

We routinely CTW 3rd party JARs to make sure our compilers work. By the nature of the JARs, they have dependencies on other JARs, and CTW runner frequently warns out with NCDFE. It does so very crudely, missing opportunities to compile the methods that do not trigger NCDFEs. CTW should be made more tolerant to this. I think the normal "modules" CTW runs into the similar problem, but on a lesser scale, as we do not have a very hairy dependency graph within JDK.

The CTW logs are also fairly noisy with full exception traces when NCDFE is semi-expected. This PR does not print exception stack traces in these cases, only "NOTE"-s about it. This makes the log fairly clean and more understandable.

Motivational scope improvement compiling a sample 3rd party JAR (cassandra-2.1.4.0.jar):

Before: Done (2487 classes, 9866 methods, 24584 ms)
After:  Done (2487 classes, 10074 methods, 24150 ms)  ; +2% more methods

Additional testing:

  • Linux x86_64 server fastdebug, applications/ctw/modules

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361255: CTW: Tolerate more NCDFE problems (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26090/head:pull/26090
$ git checkout pull/26090

Update a local copy of the PR:
$ git checkout pull/26090
$ git pull https://git.openjdk.org/jdk.git pull/26090/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26090

View PR using the GUI difftool:
$ git pr show -t 26090

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26090.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 2, 2025
@openjdk
Copy link

openjdk bot commented Jul 2, 2025

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 2, 2025

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jul 2, 2025

Sanity-checking CTW times:

$ time CONF=linux-x86_64-server-fastdebug make test TEST=applications/ctw/modules/

# Base
real	3m49.952s
user	67m50.313s
sys	5m24.288s

# This PR
real	3m53.800s
user	67m26.925s
sys	5m22.429s

try {
UNSAFE.ensureClassInitialized(aClass);
} catch (NoClassDefFoundError e) {
CompileTheWorld.OUT.printf("[%d]\t%s\tNOTE unable to init class : %s%n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean \n here and in all other outputs? %n needs local variable to store size of output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants