-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365394: Stylesheet must not load fonts on --no-fonts output #26843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @marcphilipp, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user marcphilipp" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
@marcphilipp The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
d443a89
to
990cb39
Compare
fonts/dejavu.css
if --no-fonts
is enabledfonts/dejavu.css
if --no-fonts
is enabled
@marcphilipp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
990cb39
to
13fc5ad
Compare
While copying `resources/stylesheet.css` to the target location, the line containing the CSS import statement for `fonts/dejavu.css` is now removed from the output in case the `--no-fonts` option is enabled.
13fc5ad
to
9438708
Compare
@marcphilipp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
fonts/dejavu.css
if --no-fonts
is enabled
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
While copying
resources/stylesheet.css
to the target location, theline containing the CSS import statement for
fonts/dejavu.css
is nowremoved from the output in case the
--no-fonts
option is enabled.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26843/head:pull/26843
$ git checkout pull/26843
Update a local copy of the PR:
$ git checkout pull/26843
$ git pull https://git.openjdk.org/jdk.git pull/26843/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26843
View PR using the GUI difftool:
$ git pr show -t 26843
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26843.diff
Using Webrev
Link to Webrev Comment