Skip to content

8365394: Stylesheet must not load fonts on --no-fonts output #26843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcphilipp
Copy link

@marcphilipp marcphilipp commented Aug 19, 2025

While copying resources/stylesheet.css to the target location, the
line containing the CSS import statement for fonts/dejavu.css is now
removed from the output in case the --no-fonts option is enabled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365394: Stylesheet must not load fonts on --no-fonts output (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26843/head:pull/26843
$ git checkout pull/26843

Update a local copy of the PR:
$ git checkout pull/26843
$ git pull https://git.openjdk.org/jdk.git pull/26843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26843

View PR using the GUI difftool:
$ git pr show -t 26843

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26843.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 19, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

Hi @marcphilipp, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user marcphilipp" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@marcphilipp The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@marcphilipp marcphilipp changed the title Remove CSS import of fonts/dejavu.css if --no-fonts is enabled 8365394: Remove CSS import of fonts/dejavu.css if --no-fonts is enabled Aug 19, 2025
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@marcphilipp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

While copying `resources/stylesheet.css` to the target location, the
line containing the CSS import statement for `fonts/dejavu.css` is now
removed from the output in case the `--no-fonts` option is enabled.
@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@marcphilipp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@marcphilipp marcphilipp changed the title 8365394: Remove CSS import of fonts/dejavu.css if --no-fonts is enabled 8365394: Stylesheet must not load fonts on --no-fonts output Aug 19, 2025
@marcphilipp
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Aug 19, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Aug 20, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javadoc [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant