Skip to content

8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691 #26844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Aug 19, 2025

The fix for JDK-8279005 also fixed JDK-8248691 and JDK-8268211, which latter two are closed as dups. So, I've removed all jstatLineCountsX.sh from the ProblemList. I propose this patch is trivial.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691 (Sub-task - P4)

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26844/head:pull/26844
$ git checkout pull/26844

Update a local copy of the PR:
$ git checkout pull/26844
$ git pull https://git.openjdk.org/jdk.git pull/26844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26844

View PR using the GUI difftool:
$ git pr show -t 26844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26844.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 19, 2025

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691

Reviewed-by: eastigeevich, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@phohensee To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@eastig
Copy link
Member

eastig commented Aug 19, 2025

/label add serviceability

Copy link
Member

@eastig eastig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk
Copy link

openjdk bot commented Aug 19, 2025

@eastig
The serviceability label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 19, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 19, 2025

Webrevs

@simonis
Copy link
Member

simonis commented Aug 19, 2025

@MBaesken , @ArnoZeller can you please check if the test can be removed from the problem list on linux-ppc64le and AIX?

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested on linux-aarch. I can't speak for the ppc platforms.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 19, 2025
@phohensee
Copy link
Member Author

Thanks, Chris.

@MBaesken
Copy link
Member

@MBaesken , @ArnoZeller can you please check if the test can be removed from the problem list on linux-ppc64le and AIX?

I put it into our build/tests , will run it there for some time to check for issues on the ppc platforms.
(I am out of office for some days soon so might take a bit of time until I respond again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

6 participants