-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8364382: Remove sun/tools/jstat/jstatLineCountsX.sh from ProblemList on linux-ppc64le and aix due to JDK-8248691 #26844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…on linux-ppc64le and aix due to JDK-8248691
👋 Welcome back phh! A progress list of the required criteria for merging this PR into |
@phohensee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@phohensee To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add serviceability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@eastig |
@MBaesken , @ArnoZeller can you please check if the test can be removed from the problem list on linux-ppc64le and AIX? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested on linux-aarch. I can't speak for the ppc platforms.
Thanks, Chris. |
I put it into our build/tests , will run it there for some time to check for issues on the ppc platforms. |
The fix for JDK-8279005 also fixed JDK-8248691 and JDK-8268211, which latter two are closed as dups. So, I've removed all jstatLineCountsX.sh from the ProblemList. I propose this patch is trivial.
Progress
Issue
Reviewers
Reviewers without OpenJDK IDs
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26844/head:pull/26844
$ git checkout pull/26844
Update a local copy of the PR:
$ git checkout pull/26844
$ git pull https://git.openjdk.org/jdk.git pull/26844/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26844
View PR using the GUI difftool:
$ git pr show -t 26844
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26844.diff
Using Webrev
Link to Webrev Comment