-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8364764: java/nio/channels/vthread/BlockingChannelOps.java subtests timed out #26847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me.
/integrate |
Going to push as commit f0498c2.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit f0498c2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
4 tests (testSocketChannelWriteAsyncClose, testSocketChannelWriteInterrupt, testPipeWriteAsyncClose testPipeWriteInterrupt) test async close/interrupt when a virtual thread is blocked in write. This is difficult to test as the target thread may wakeup with bytes written (so it returns the number of bytes written rather than throw). The test is changed to "nudge" the writer a few times so that the writer eventually wakes up with no bytes written.
Additionally, two tests are added to test async shutdownInput and shutdownOutput.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26847/head:pull/26847
$ git checkout pull/26847
Update a local copy of the PR:
$ git checkout pull/26847
$ git pull https://git.openjdk.org/jdk.git pull/26847/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26847
View PR using the GUI difftool:
$ git pr show -t 26847
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26847.diff
Using Webrev
Link to Webrev Comment