8356289: Shenandoah: Clean up SATB barrier runtime entry points

[JohnTortugo]

The runtime entry points for the SATB slow-paths currently take a JavaThread* argument. When @rkennke did the entry points for Graal (JDK-8356075), he figured that we do not really need them. The slow-path is only called rarely (whenever the local SATB buffer is full), and getting the current Thread* in the runtime would not be the expensive part.

This PR is a patch to do that clean up. The changes were tested on Linux x64/aarch64 with JTREG tier1-3 using Shenandoah for all tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356289: Shenandoah: Clean up SATB barrier runtime entry points (Enhancement - P4)

Reviewers

• Kelvin Nilsen (@kdnilsen - Committer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)
• William Kemper (@earthling-amzn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26850/head:pull/26850
$ git checkout pull/26850

Update a local copy of the PR:
$ git checkout pull/26850
$ git pull https://git.openjdk.org/jdk.git pull/26850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26850

View PR using the GUI difftool:
$ git pr show -t 26850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26850.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cslucas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JohnTortugo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356289: Shenandoah: Clean up SATB barrier runtime entry points

Reviewed-by: kdnilsen, ysr, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• 603526b: 8364768: JDK javax.imageio ImageWriters do not all flush the output stream
• c01b4fc: 8365814: Consolidate has_been_archived() and has_been_buffered() in ArchiveBuilder
• ae0dac4: 8361613: System.console() should only be available for interactive terminal
• ... and 128 more: https://git.openjdk.org/jdk/compare/87d734012e3130501bfd37b23cee7f5e0a3a476f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@JohnTortugo The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (86fc5875)

[kdnilsen]

Looks good to me. Have we run this change through our internal CI regression pipelines?

[earthling-amzn]

Looks reasonable to me. I have the same question as @kdnilsen .

[ysramakrishna]

Same; performance impact would be good to know (i.e. that it's performance neutral or may be even a bit better).

[earthling-amzn]

Internal testing looks good.

[JohnTortugo]

I reviewed the tests internally with @earthling-amzn ; He said everything looks good.

[JohnTortugo]

/integrate

[openjdk]

Going to push as commit f28f618.
Since your change was applied there have been 131 commits pushed to the master branch:

• 603526b: 8364768: JDK javax.imageio ImageWriters do not all flush the output stream
• c01b4fc: 8365814: Consolidate has_been_archived() and has_been_buffered() in ArchiveBuilder
• ae0dac4: 8361613: System.console() should only be available for interactive terminal
• ... and 128 more: https://git.openjdk.org/jdk/compare/87d734012e3130501bfd37b23cee7f5e0a3a476f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JohnTortugo Pushed as commit f28f618.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.