8365841: RISC-V: Several IR verification tests fail after JDK-8350960 without Zvfh

[DingliZhang]

Hi,
Can you help to review this patch? Thanks!

The error in both cases is caused by the same reason: the target IR, MulReductionVI, is not matched.
This is because the match_rule_supported_vector in riscv_v.ad is missing a break. If the if condition in case MulReductionVI evaluates to false, the loop will not exit until the return UseZvfh.

Failed IR tests:
compiler/loopopts/superword/ProdRed_Int.java
compiler/loopopts/superword/RedTest_int.java

Test (fastdebug)

• Run compiler/loopopts/superword/ProdRed_Int.java on k1 and k230
• Run compiler/loopopts/superword/RedTest_int.java on k1 and k230

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365841: RISC-V: Several IR verification tests fail after JDK-8350960 without Zvfh (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Feilong Jiang (@feilongjiang - Committer)
• Hamlin Li (@Hamlin-Li - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26854/head:pull/26854
$ git checkout pull/26854

Update a local copy of the PR:
$ git checkout pull/26854
$ git pull https://git.openjdk.org/jdk.git pull/26854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26854

View PR using the GUI difftool:
$ git pr show -t 26854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26854.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365841: RISC-V: Several IR verification tests fail after JDK-8350960 without Zvfh

Reviewed-by: fyang, fjiang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• ecab52c: 8365610: Sort share/jfr includes
• ed7d5fe: 8360304: Redundant condition in LibraryCallKit::inline_vector_nary_operation
• be6c15e: 8365671: Typo in Joiner.allUntil example
• ... and 15 more: https://git.openjdk.org/jdk/compare/b453eb63c641e1e69b4aef57a220ebe45b9d1693...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (33dd53a9)

[RealFYang]

Good catch! Thanks.

[feilongjiang]

Thanks!

[DingliZhang]

Hi @Hamlin-Li , could you help to review this patch?

[Hamlin-Li]

Looks good, thanks for fixing this!

[DingliZhang]

Thanks all for the review!
/integrate

[openjdk]

@DingliZhang
Your change (at version 33dd53a) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 2e06a91.
Since your change was applied there have been 18 commits pushed to the master branch:

• ecab52c: 8365610: Sort share/jfr includes
• ed7d5fe: 8360304: Redundant condition in LibraryCallKit::inline_vector_nary_operation
• be6c15e: 8365671: Typo in Joiner.allUntil example
• ... and 15 more: https://git.openjdk.org/jdk/compare/b453eb63c641e1e69b4aef57a220ebe45b9d1693...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @DingliZhang Pushed as commit 2e06a91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.