8365844: RISC-V: TestBadFormat.java fails when running without RVV

[DingliZhang]

Hi,
Can you help to review this patch? Thanks!

We noticed that testlibrary_tests/ir_framework/tests/TestBadFormat.java fails when running tier4 tests on p550.
The reason for the error is that the Vector test related to badVectorNodeSize requires RVV on riscv, otherwise the expected passing case will fail and cannot match FailCount.

Test (fastdebug)

• Run testlibrary_tests/ir_framework/tests/TestBadFormat.java on k1/k230/sg2042

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365844: RISC-V: TestBadFormat.java fails when running without RVV (Bug - P4)

Reviewers

• Feilong Jiang (@feilongjiang - Committer)
• Christian Hagedorn (@chhagedorn - Reviewer)
• Emanuel Peter (@eme64 - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26855/head:pull/26855
$ git checkout pull/26855

Update a local copy of the PR:
$ git checkout pull/26855
$ git pull https://git.openjdk.org/jdk.git pull/26855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26855

View PR using the GUI difftool:
$ git pr show -t 26855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26855.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365844: RISC-V: TestBadFormat.java fails when running without RVV

Reviewed-by: fjiang, chagedorn, epeter, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 3468c6e: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI
• 5274725: 8154364: (fs) Files.isSameFile() throws NoSuchFileException with broken symbolic links
• 11eccfc: 8365917: Sort share/logging includes
• ... and 36 more: https://git.openjdk.org/jdk/compare/b453eb63c641e1e69b4aef57a220ebe45b9d1693...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@feilongjiang, @chhagedorn, @eme64, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (0390a6ef)
• 01: Full - Incremental (d4468d61)
• 00: Full (1b9f1698)

[DingliZhang]

Update: TestBadFormat.java passed on k1/k230/sg2042 with applyIf = {"MaxVectorSize", ">0"}

[chhagedorn]

Thanks for the update and trying it out! That looks cleaner now. A small improvement suggestion but otherwise, it looks good to me.

[chhagedorn]

Looks good, thanks for the updates!

[eme64]

Looks good now, thanks @chhagedorn for the idea!

[RealFYang]

LGTM. Thanks.

[DingliZhang]

Thanks all for the review!
/integrate

[openjdk]

@DingliZhang
Your change (at version 0390a6e) is now ready to be sponsored by a Committer.

[feilongjiang]

/sponsor

[openjdk]

Going to push as commit 584137c.
Since your change was applied there have been 39 commits pushed to the master branch:

• 3468c6e: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI
• 5274725: 8154364: (fs) Files.isSameFile() throws NoSuchFileException with broken symbolic links
• 11eccfc: 8365917: Sort share/logging includes
• ... and 36 more: https://git.openjdk.org/jdk/compare/b453eb63c641e1e69b4aef57a220ebe45b9d1693...master

Your commit was automatically rebased without conflicts.

[openjdk]

@feilongjiang @DingliZhang Pushed as commit 584137c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.