Support anonymous, local and JDK nested classes in TOOLING.jsh's javap function
#26864
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And correctly report actually unsupported classes
|
👋 Welcome back altrisi! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
liach
reviewed
Aug 20, 2025
liach
reviewed
Aug 20, 2025
| @@ -9,8 +9,8 @@ void jpackage(String... args) { run("jpackage", args); } | |||
|
|
|||
| void javap(Class<?> type) throws Exception { | |||
| try { | |||
| var name = type.getCanonicalName(); | |||
| if (name == null) throw new IllegalArgumentException("Type not supported: " + type); | |||
| if (type.isPrimitive() || type.isHidden() || type.isArray()) throw new IllegalArgumentException("Type not supported: " + type); | |||
There was a problem hiding this comment.
The message should say the given class has no class file. And this check should be hoisted out of the try-catch.
It's enough with just the user-created one, which is reliable and won't cause failures if the class being targeted is refactored
|
Created https://bugs.openjdk.org/browse/JDK-8365878 for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes TOOLING.jsh's
javapfunction support anonymous, local and built-in nested classes.Note that nested classes created in jshell would previously work, but not JDK ones as they'd miss the is built-in check (wrong name for
Class.forName) and later throw an exception because of a null classloader.The rest of classes would fail the canonical name check, which wouldn't allow them to be disassembled.
This change makes them work by changing the check from canonicalName != null to specific checks for unsupported types of classes, and doing Class.forName using the result of getName(), not the canonical name, for the built-in check.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26864/head:pull/26864$ git checkout pull/26864Update a local copy of the PR:
$ git checkout pull/26864$ git pull https://git.openjdk.org/jdk.git pull/26864/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26864View PR using the GUI difftool:
$ git pr show -t 26864Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26864.diff