8365407: Race condition in MethodTrainingData::verify()

[veresov]

This change fixes multiple issue with training data verification. While the current state of things in the mainline will not cause any issues (because of the absence of the call to TD::verify() during the shutdown) it does problems in the leyden repo. This change strengthens verification in the mainline (by adding the shutdown verify call), and fixes the problems that prevent it from working reliably.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365407: Race condition in MethodTrainingData::verify() (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26866/head:pull/26866
$ git checkout pull/26866

Update a local copy of the PR:
$ git checkout pull/26866
$ git pull https://git.openjdk.org/jdk.git pull/26866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26866

View PR using the GUI difftool:
$ git pr show -t 26866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26866.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@veresov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (c33d94bc)
• 05: Full - Incremental (f7d6a4e0)
• 04: Full - Incremental (edc8591d)
• 03: Full - Incremental (289fb74c)
• 02: Full - Incremental (3a4690fc)
• 01: Full - Incremental (b9dde139)
• 00: Full (997b4858)

[veresov]

/label add hotspot-compiler

[openjdk]

@veresov
The hotspot-compiler label was successfully added.

[dholmes-ora]

Just a few drive-by comments as I'm not familiar with this "training" stuff.

[vnkozlov]

Will it loop forever with + AOTVerifyTrainingData ?

[veresov]

Yes, it runs in a dedicated thread. It doesn't need to terminate.

[vnkozlov]

Add comment about this.