Skip to content

8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet #26867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 94 commits into
base: master
Choose a base branch
from

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Aug 20, 2025

This PR eliminates redundant bookkeeping that had been carried out by both ShenandoahGeneration and ShenandoahFreeSet. In the new code, we keep a single tally of relevant information within ShenandoahFreeSet.
Queries serviced by ShenandoahGeneration are now delegated to ShenandoahFreeSet.

This change eliminates rare and troublesome assertion failures that were often raised when the ShenandoahFreeSet tallies did not match the ShenandoahGeneration tallies. These assertion failures resulted because the two sets of books are updated at different times, using different synchronization mechanisms.

The other benefit of this change is that we have less synchronization overhead because we only have to maintain a single set of books.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26867/head:pull/26867
$ git checkout pull/26867

Update a local copy of the PR:
$ git checkout pull/26867
$ git pull https://git.openjdk.org/jdk.git pull/26867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26867

View PR using the GUI difftool:
$ git pr show -t 26867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26867.diff

@kdnilsen kdnilsen marked this pull request as draft August 20, 2025 19:17
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@kdnilsen The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@kdnilsen kdnilsen changed the title Freeset has authoritative tallies 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant