-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet #26867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kdnilsen
wants to merge
94
commits into
openjdk:master
Choose a base branch
from
kdnilsen:freeset-has-authoritative-tallies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet #26867
kdnilsen
wants to merge
94
commits into
openjdk:master
from
kdnilsen:freeset-has-authoritative-tallies
+2,364
−1,118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates redundant bookkeeping that had been carried out by both ShenandoahGeneration and ShenandoahFreeSet. In the new code, we keep a single tally of relevant information within ShenandoahFreeSet.
Queries serviced by ShenandoahGeneration are now delegated to ShenandoahFreeSet.
This change eliminates rare and troublesome assertion failures that were often raised when the ShenandoahFreeSet tallies did not match the ShenandoahGeneration tallies. These assertion failures resulted because the two sets of books are updated at different times, using different synchronization mechanisms.
The other benefit of this change is that we have less synchronization overhead because we only have to maintain a single set of books.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26867/head:pull/26867
$ git checkout pull/26867
Update a local copy of the PR:
$ git checkout pull/26867
$ git pull https://git.openjdk.org/jdk.git pull/26867/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26867
View PR using the GUI difftool:
$ git pr show -t 26867
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26867.diff