Skip to content

Conversation

mpdonova
Copy link
Contributor

@mpdonova mpdonova commented Aug 20, 2025

This PR updates ArtifactResolver.fetchOne() to throw an IOException instead of SkippedException. This allows tests to determine of a missing "artifact" should be treated as a failed or skipped test.OpensslArtifactFetcher is also updated to only throw SkippedException if OpenSSL is not available on the test platform.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360882: Tests throw SkippedException when they should fail (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26868/head:pull/26868
$ git checkout pull/26868

Update a local copy of the PR:
$ git checkout pull/26868
$ git pull https://git.openjdk.org/jdk.git pull/26868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26868

View PR using the GUI difftool:
$ git pr show -t 26868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26868.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2025

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 20, 2025

@mpdonova The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security [email protected] rfr Pull request is ready for review labels Aug 20, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2025

Webrevs

@@ -48,43 +49,39 @@ public class OpensslArtifactFetcher {
and return that path, if download fails then return null.
*
* @return openssl binary path of the current version
* @throws SkippedException if a valid version of OpenSSL cannot be found
* @throws IOException if a valid version of OpenSSL cannot be found
Copy link

@ExE-Boss ExE-Boss Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still also throws SkippedException:

throw new SkippedException(String.format("No OpenSSL %s found for %s/%s",
OPENSSL_BUNDLE_VERSION, Platform.getOsName(), Platform.getOsArch()));

Suggested change
* @throws IOException if a valid version of OpenSSL cannot be found
* @throws IOException if a valid version of OpenSSL cannot be found
* @throws SkippedException if OpenSSL is not available on the target platform

@@ -48,43 +49,40 @@ public class OpensslArtifactFetcher {
and return that path, if download fails then return null.
*
* @return openssl binary path of the current version
* @throws SkippedException if a valid version of OpenSSL cannot be found
* @throws SkippedException if OpenSSL is not available on the target platform

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SkippedException is now thrown in all cases, the JavaDoc @throws clauses should be merged.

Suggested change
* @throws SkippedException if OpenSSL is not available on the target platform
* @throws SkippedException if a valid version of OpenSSL cannot be found
* or if OpenSSL is not available on the target platform

@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants