8365815: JFR: Update metadata.xml with 'jfr query' examples #26869
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could I have a review of a PR that adds a couple of 'jfr query' examples to metadata.xml?
It turns out that the EventDuration event doesn't work because it has no fields. The fix is to remove the class-specific commit() method and constructor for events without fields.
Testing: test/jdk/jdk/jfr + tier1
Thanks
Erik
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26869/head:pull/26869
$ git checkout pull/26869
Update a local copy of the PR:
$ git checkout pull/26869
$ git pull https://git.openjdk.org/jdk.git pull/26869/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26869
View PR using the GUI difftool:
$ git pr show -t 26869
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26869.diff
Using Webrev
Link to Webrev Comment