8365885: Clean up constant pool reflection native code #26870
+139
−124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to reuse this constant pool reflection for assembly phase indy argument validation, I noted the JNI code has a lot of confusing arguments. In particular, the JVM_ConstantPoolGetSize is wrong because of argument confusion. We should remove the unused arguments to reduce confusion.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26870/head:pull/26870
$ git checkout pull/26870
Update a local copy of the PR:
$ git checkout pull/26870
$ git pull https://git.openjdk.org/jdk.git pull/26870/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26870
View PR using the GUI difftool:
$ git pr show -t 26870
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26870.diff
Using Webrev
Link to Webrev Comment