8355249: Remove the use of WMIC from the entire source code #3688
+31
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
bot
added
backport
|
Thank you for your review about jdk21 and jdk11. |
alexeysemenyukoracle
approved these changes
Jul 16, 2025
|
jpackage changes look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code
JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.
Original patch does not apply cleanly because JDK-8340311 is not backported to jdk17. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.
In addition, JDK-8344275 doesn't apply to 17, and NosuchElementException is only used in 17, so I made a slightly different fix for those as well.
I confirmed that Win8301247Test.java passes on Windows Server 2022.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3688/head:pull/3688$ git checkout pull/3688Update a local copy of the PR:
$ git checkout pull/3688$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3688/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3688View PR using the GUI difftool:
$ git pr show -t 3688Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3688.diff
Using Webrev
Link to Webrev Comment