Skip to content

8276046: codestrings.validate_vm gtest fails on ppc64, s390 #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 15, 2025

I backport this as follow up of JDK-8264207


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8276046 needs maintainer approval

Issue

  • JDK-8276046: codestrings.validate_vm gtest fails on ppc64, s390 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3751/head:pull/3751
$ git checkout pull/3751

Update a local copy of the PR:
$ git checkout pull/3751
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3751

View PR using the GUI difftool:
$ git pr show -t 3751

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3751.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276046: codestrings.validate_vm gtest fails on ppc64, s390

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 809488bf38c250db3c263f200e5eb1a269059c3d 8276046: codestrings.validate_vm gtest fails on ppc64, s390 Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 17, 2025
@RealCLanger
Copy link
Contributor

/approve yes

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@RealCLanger
8276046: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 17, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jul 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

Going to push as commit 4a6afcc.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2025
@openjdk openjdk bot closed this Jul 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@GoeLin Pushed as commit 4a6afcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants