-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903883: --verify-exclude test existence and format checks are broken #236
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, left some requests regarding a TODO
comment and optional verbose output.
// TODO We know set of suites here, could save/do dummy | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// TODO We know set of suites here, could save/do dummy |
Please don't add TODO
comments — just do it, or don't.
Thank you for reviewing @sormuras. I agree with all your comments and have addressed them. I chose to put the test names behind -va because that's a huuuuge list for the jdk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.
As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.
Additionally, the regex for problemlist format had a typo.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/236/head:pull/236
$ git checkout pull/236
Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.org/jtreg.git pull/236/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 236
View PR using the GUI difftool:
$ git pr show -t 236
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/236.diff
Using Webrev
Link to Webrev Comment