Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903883: --verify-exclude test existence and format checks are broken #236

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

LudwikJaniuk
Copy link

@LudwikJaniuk LudwikJaniuk commented Nov 13, 2024

The way this feature selected "the full set of tests" was actually getting "the set of tests to be run". But often, we run some subset through either specifying test files, folders, or groups. Our problemlist files will still have entries for other tests we were not running right now.

As a solution, --verify-exclude needs to compute the maximal set of tests that could be run for all test suites that any of the tests being run are a part of. I've implemented this by creating a dummy testmanager and passing no parameters to it.

Additionally, the regex for problemlist format had a typo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7903883: --verify-exclude test existence and format checks are broken (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.org/jtreg.git pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/236.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903883 --verify-exclude test existence and format checks are broken 7903883: --verify-exclude test existence and format checks are broken Nov 13, 2024
@LudwikJaniuk LudwikJaniuk changed the title 7903883: --verify-exclude test existence and format checks are broken (draft) 7903883: --verify-exclude test existence and format checks are broken Nov 13, 2024
@LudwikJaniuk LudwikJaniuk changed the title (draft) 7903883: --verify-exclude test existence and format checks are broken 7903883: --verify-exclude test existence and format checks are broken Nov 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, left some requests regarding a TODO comment and optional verbose output.

Comment on lines 1183 to 1184
// TODO We know set of suites here, could save/do dummy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO We know set of suites here, could save/do dummy

Please don't add TODO comments — just do it, or don't.

src/share/classes/com/sun/javatest/regtest/tool/Tool.java Outdated Show resolved Hide resolved
@LudwikJaniuk
Copy link
Author

LudwikJaniuk commented Nov 15, 2024

Thank you for reviewing @sormuras. I agree with all your comments and have addressed them. I chose to put the test names behind -va because that's a huuuuge list for the jdk.

Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants