fix cloneSet controller block caused by scale expectation leakage #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
+ Coverage 47.91% 50.07% +2.16%
==========================================
Files 162 192 +30
Lines 23491 24666 +1175
==========================================
+ Hits 11256 12352 +1096
- Misses 11014 11044 +30
- Partials 1221 1270 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
zmberg
force-pushed
the
fix-cloneset-block
branch
2 times, most recently
from
4f32307
to
bec8746
Compare
furykerry
reviewed
Nov 19, 2024
| klog.InfoS("Expectation unsatisfied overtime", "cloneSet", request, "scaleDirtyPods", scaleDirtyPods, "overTime", unsatisfiedDuration) | ||
| // In some extreme scenarios, if the Pod is created and then quickly deleted, there may be event loss. | ||
| // Therefore, a touting mechanism is needed to ensure that clonesets can continue to work. | ||
| klog.InfoS("Expectation unsatisfied overtime, and delete ScaleExpectation", "cloneSet", request, "scaleDirtyPods", scaleDirtyPods, "overTime", unsatisfiedDuration) |
| // Therefore, a touting mechanism is needed to ensure that clonesets can continue to work. | ||
| klog.InfoS("Expectation unsatisfied overtime, and delete ScaleExpectation", "cloneSet", request, "scaleDirtyPods", scaleDirtyPods, "overTime", unsatisfiedDuration) | ||
| CloneSetScaleExpectationLeakageMetrics.WithLabelValues(request.Namespace, request.Name).Add(1) | ||
| // todo, currently there is no way to differentiate between the two resources pod/pvc, so the pvc needs to be separated by an expectation |
There was a problem hiding this comment.
//TODO: check the existence of resource in apiserver using client-go directly
Signed-off-by: liheng.zms <[email protected]>
zmberg
force-pushed
the
fix-cloneset-block
branch
from
bec8746
to
9af3264
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
#1765
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews