Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imagepulljob imagePullPolicy=Always does not take effect #1830

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Nov 19, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#1814

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.96%. Comparing base (0d0031a) to head (db33b1f).
Report is 121 commits behind head on master.

Files with missing lines Patch % Lines
...controller/imagepulljob/imagepulljob_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   47.91%   49.96%   +2.05%     
==========================================
  Files         162      192      +30     
  Lines       23491    24642    +1151     
==========================================
+ Hits        11256    12313    +1057     
- Misses      11014    11054      +40     
- Partials     1221     1275      +54     
Flag Coverage Δ
unittests 49.96% <0.00%> (+2.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@furykerry furykerry merged commit 3e225bb into openkruise:master Nov 19, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants