-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring only exact "vacuum" assignment is detected as vacuum #3264
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
Co-authored-by: Jonathan Shimwell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bam241 I took a crack at simplifying this test somewhat. I'm pretty sure it still tests what you're intending, but let me know if I'm missing something.
I don't have a suggestion on how to re-use the model
fixture above here. I don't think it's too important though as the materials in this test could be anything as long as their names are set appropriately.
Description
This is a follow up on svalinn/DAGMC#805
This ensures that a assignment named "not_a_vacuum" is not flagged as vacuum and therefore is not assigned with vacuum boundary condition.
Fixes # (issue)
This is related to #3218
I also had to implement that a different way than initially expected.
I first thought about leveraging the #3056 PR recently merged to do this kind of test.
But, vacuum detection is perform (in the
DAGMC
workflow withinopenMC
) before applying materials assignment (therefore before overriding)This is why I implemented this by making temporary copy of the
dagmc.hm5
and modifying them. (Not that seing how simple this is we could potentially provide a method that allows to do that withindagmc.py
?)I trying and failed to design this test as a fixture, I don't know why it failed it never recognised the returned
model
as aopenmc.Model
but as a function... (@pshriwise if you have any insight on this ?)Checklist
This works is sponsored by Proxima Fusion