-
Notifications
You must be signed in to change notification settings - Fork 544
Multi-group capability for kinetics parameter calculations with Iterated Fission Probability #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapting of the tally scores to give multigroup beta-effective values when passed a delayed group filter.
Fixed setting the Tally Index for the DelayedGroup Filter.
changed @lru_cache to the lighter @cache from Python 3.9 added _init_ifp() to automatically create IFP tallies for the enabled setting and ifp_results() for quick data retrieval with automatic arithmetic.
changed @lru_cache to the lighter @cache from Python 3.9 added _init_ifp() to automatically create IFP tallies for the enabled setting and ifp_results() for quick data retrieval with automatic arithmetic.
…/openmc-ifp into kinetics_ifp_mpi_optim
… IFP tally is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adaptation of existing kinetics parameter calculations using Iterated Fission Probability (IFP) to provide multi-group effective delayed neutron fractions. This adaptation of the current IFP implementation added in 47ca291 will allow OpenMC to generate all parameters necessary for full 6-group point kinetics modelling.
Additional convenience functions will be added to build on top of #3133 to streamline enabling full kinetics parameter calculations and provision. Ideally, the
openmc.model.Model
class will be modified to automatically initialize all the necessary tallies when the appropriate IFP settings are created in theopenmc.Settings
. Adjustments toopenmc.Statepoint
will handle the calculation of the parameters from the existing tallies and provide the parameters.Development is being done with support from @sallustius and @JoffreyDorville.
Checklist