(fix) Standardize modal header close button styles #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizes the positioning and styling of modal close buttons across the application by: - Adding consistent modal header styles across all modals - Positioning close buttons absolutely in the top-right corner - Adding hover state styling for close buttons - Fixing popover positioning for left-aligned modals This change affects modals in: - Appointments app - Bed management app - Patient registration app - Service queues app This resolves an issue that we think is caused by Carbon version mismatches. The hope is that this [pull request](openmrs/openmrs-esm-core#1215) in Core will fix the issue more permanently.
|
Size Change: -49 kB (-0.68%) Total Size: 7.2 MB
ℹ️ View Unchanged
|
NethmiRodrigo
approved these changes
Dec 18, 2024
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Standardizes the positioning and styling of modal close buttons across the application by:
This change affects modals in:
This resolves an issue that we think is caused by Carbon version mismatches. The hope is that this pull request in Core will fix the issue more permanently.
Screenshots
Before
After
There's still one issue with the modals in the bed management app - launching the modals immediately applies focus to the close button. I've not looked at this in depth, but my current suspicion is that that's happening because those modals haven't fully been ported over to reusing the modal container that Core ships. This open PR will effect that migration, and hopefully fix this issue.
Related Issue
Other
We've seen this happen before in the Form Builder, where we applied a similar workaround.